Cleanup/imports parsing #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoser
force-pushed
the
cleanup/imports-parsing
branch
3 times, most recently
from
6be6698 to
fb633a3
Compare
Instead of using '-1' to indicate "do not change userid" (or groupid) to FileCopy, provide constants UidEmpty and GidEmpty. Also add simplified FileCopyNoPerms to call FileCopy without mode or uid/gid. Signed-off-by: Scott Moser <[email protected]>
smoser
force-pushed
the
cleanup/imports-parsing
branch
5 times, most recently
from
bb66ba0 to
0aa3618
Compare
… tests
There is one change here, and that is to break if a stacker yaml
has an import that is a dictionary type. The content in an 'import'
is now only supported as a string or a list, not a dictionary.
For example, these are allowed:
* import: /path/to/file
* import:
- /file
- /file2
- path: /file3
But this is not:
* import:
path: /file3
Improvements here:
* Drop duplicate code blocks from getImportFromInterface
There were 2 identical codeblocks, one with a type convert to
map[string]interface{} and one with type convert to
map[interface{}]interface{}. That was present to handle the dict
case.
* Add some golang tests to for unmarshalling.
* Type check the values of all string Import fields, rather than just
converting them to a string with 'fmt.Sprintf("%v")'
Signed-off-by: Scott Moser <[email protected]>
smoser
force-pushed
the
cleanup/imports-parsing
branch
from
0aa3618 to
93eaf9c
Compare
|
@mikemccracken @hallyn pls review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Improvements to yaml.Unmarshal for types.Imports and add some go tests
Improvements here:
There were 2 identical codeblocks, one with a type convert to
map[string]interface{} and one with type convert to
map[interface{}]interface{}. I cannot find any reason for the
former
converting them to a string with 'fmt.Sprintf("%v")'
cleanup: Add contsants UidEmpty and GidEmpty and FileCopyNoPerms function.
Instead of using '-1' to indicate "do not change userid" (or groupid)
to FileCopy, provide constants UidEmpty and GidEmpty.
Also add simplified FileCopyNoPerms to call FileCopy without mode
or uid/gid.